Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI config and implement on WASM #10

Merged
merged 10 commits into from
Feb 26, 2019
Merged

Add CI config and implement on WASM #10

merged 10 commits into from
Feb 26, 2019

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Feb 25, 2019

Some failures are expected for now:

  • WASM support needs implementing
  • WASM test needs to be copied from Rand
  • doc links need fixing

Some may fail:

  • Android support was having problems on Rand
  • Fuchsia tests were disabled following problems

See also rust-random/rand#743

@dhardy dhardy changed the title Add CI config Add CI config and implement on WASM Feb 25, 2019
@dhardy
Copy link
Member Author

dhardy commented Feb 25, 2019

@newpavlov review please?

There are a few errors I didn't know what to do with.

@newpavlov
Copy link
Member

Hm, I am not that knowledgeable about CI setups and WASM, so not sure if I will be able to help. At a cursory look I couldn't find anything out of place. I think that after fixing the obvious failures it will be better to link this PR on users forum and reddit and ask for reviews.

Also new: impl From<NonZeroU32> for Error
We currently don't support old enough compilers to require this.
@dhardy
Copy link
Member Author

dhardy commented Feb 25, 2019

Lets see how many of the failures the last patch fixes...

I'm not too concerned about reviewing the Travis config; I have a reasonable understanding of what it does even if I dislike poking it. I've also tested the WASM stuff locally, including with intentionally-failing tests.

But @newpavlov I would like your opinion on the code changes to the lib itself.

BTW I brought the cloudabi lib back as a dependency; I prefer to make use of external API crates where they exist (libc, winabi). The fact that all builds pull this in is a Cargo bug I hope they fix soon (apparently quite substantial changes are planned for this year).

@newpavlov
Copy link
Member

But @newpavlov I would like your opinion on the code changes to the lib itself.

Looks good to me!

@dhardy dhardy merged commit 679c52c into rust-random:master Feb 26, 2019
@dhardy dhardy mentioned this pull request Feb 26, 2019
@dhardy dhardy deleted the ci branch March 1, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants