-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI config and implement on WASM #10
Conversation
Some of these tests will fail for now!
Arguably the doc links and root URL are wrong, but they avoid broken links and will do for now.
@newpavlov review please? There are a few errors I didn't know what to do with. |
Hm, I am not that knowledgeable about CI setups and WASM, so not sure if I will be able to help. At a cursory look I couldn't find anything out of place. I think that after fixing the obvious failures it will be better to link this PR on users forum and reddit and ask for reviews. |
Also new: impl From<NonZeroU32> for Error
We currently don't support old enough compilers to require this.
Lets see how many of the failures the last patch fixes... I'm not too concerned about reviewing the Travis config; I have a reasonable understanding of what it does even if I dislike poking it. I've also tested the WASM stuff locally, including with intentionally-failing tests. But @newpavlov I would like your opinion on the code changes to the lib itself. BTW I brought the |
Looks good to me! |
Some failures are expected for now:
Some may fail:
See also rust-random/rand#743